Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename current amounts to recent, etc. Deprecate old. #2109

Closed
wants to merge 1 commit into from

Conversation

erights
Copy link
Member

@erights erights commented Dec 21, 2020

Fixes #2100

#documentation-branch: current-patch-21-12-20

@erights erights marked this pull request as ready for review December 21, 2020 21:36
@erights
Copy link
Member Author

erights commented Dec 21, 2020

Agoric/documentation#408 should fix the remaining failure.

@tyg tyg self-requested a review December 22, 2020 00:29
Copy link
Contributor

@katelynsills katelynsills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's wait for companion documentation from @tyg before merging

packages/dapp-svelte-wallet/api/src/types.js Show resolved Hide resolved
@katelynsills katelynsills added the ERTP package: ERTP label Feb 9, 2021
@katelynsills
Copy link
Contributor

Closing as we have decided not to make this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ERTP package: ERTP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename purse getCurrentAmount to getRecentAmount and deprecate getCurrentAmount
3 participants